Route update to call aliased Controller class #2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her than the one within its own namespace. Signed-off-by: Kirk Bushell <torm3nt@gmail.com>
|
I had the same issue, +1 |
taylorotwell
added a commit
that referenced
this pull request
May 28, 2013
Route update to call aliased Controller class
|
This appears to have been lost with the L3 package being pulled into an L3 branch on laravel/laravel? |
|
I don't know what you're referring to? On Jun 24, 2013, at 5:13 PM, Kirk Bushell notifications@github.com wrote:
|
|
This change was made for L3 a month ago, but when 3.0 branch was created - it seems to have been omitted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered an issue recently where we needed to make some updates to Controller (so that we could namespace our controllers), meaning we needed to update call/resolve methods also. However, what we found is that Route never called the aliased Controller class. This patch fixes that by ensuring the aliased class "Controller" is always called, instead of the Controller class within its own namespace (which is the default setup in config/application.php).