Skip to content

Add MIT license info to composer.json #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rtablada
Copy link

@rtablada rtablada commented Jun 3, 2013

By Composer convention, the license information should be included in the composer.json file. This will allow the license to show up when pulling things from composer as well as showing info on the packagist page.

@taylorotwell
Copy link
Member

I didn't know if this made sense in the "app" package. All of the dependencies have the MIT license in their composer files, but this would be your app, so does it make sense to put a license here?

@rtablada
Copy link
Author

rtablada commented Jun 3, 2013

I think given the new install method of using composer create-project it makes sense to include this in the app skeleton as well.

Sent from Mailbox for iPhone

On Mon, Jun 3, 2013 at 11:34 AM, Taylor Otwell notifications@github.com
wrote:

I didn't know if this made sense in the "app" package. All of the dependencies have the MIT license in their composer files, but this would be your app, so does it make sense to put a license here?

Reply to this email directly or view it on GitHub:
#2065 (comment)

@ShawnMcCool
Copy link

On a related note, I'd love it if the app skeleton didn't come with readme / license stuff. But, I can see how that'd make GitHub browsing less optimal.

@franzliedke
Copy link
Contributor

@ShawnMcCool You might be able to do something like that with a script that removes some of those files in Composer's post-create-project-cmd hook.

@purwandi
Copy link
Contributor

@taylorotwell please close this issue, already fix on #2278

@crynobone
Copy link
Member

@ShawnMcCool or we could add those in .gitattributes as export-ignore, it would work on --prefer-dist install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants