-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Use no protocol to fetch Lato font #3234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,6 +1,6 @@ | |||
<html> | |||
<head> | |||
<link href='http://fonts.googleapis.com/css?family=Lato:100' rel='stylesheet' type='text/css'> | |||
<link href='https://fonts.googleapis.com/css?family=Lato:100' rel='stylesheet' type='text/css'> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be //fonts.googleapis.com/css?family=Lato:100
with out protocol :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joecohens Changed just now.. :) 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I commented and 1 second later you second commit was pushed lol.
👍 |
Should be squashed to one commit. :) |
@GrahamCampbell Lol.. Sorry about that. Moments of epiphany got me doing two commits. :) |
Lol |
When using https://example.com, the welcome page design looks off due to fetching the Lato font on http://. Ref: laravel/framework#7159 Better yet, instead of https:// or http://, //
7c4fe55
to
8bf428c
Compare
@joecohens This is all your fault. :-P :) @GrahamCampbell Done. Does that work? |
Does this work on local machine with localhost? |
I don't see why it wouldn't? |
Relative links will work as long as the page is served (unlike say, opening a HTML file from your local disk in your browser). |
Use no protocol to fetch Lato font
Awesome! Thank you @taylorotwell. |
When using https://example.com, the welcome page design looks off due to fetching the Lato font on http://.
Ref: laravel/framework#7159
Update: Using no protocol i.e
//