Skip to content

Use no protocol to fetch Lato font #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2015

Conversation

DavidLemayian
Copy link
Contributor

When using https://example.com, the welcome page design looks off due to fetching the Lato font on http://.

Ref: laravel/framework#7159

Update: Using no protocol i.e //

@@ -1,6 +1,6 @@
<html>
<head>
<link href='http://fonts.googleapis.com/css?family=Lato:100' rel='stylesheet' type='text/css'>
<link href='https://fonts.googleapis.com/css?family=Lato:100' rel='stylesheet' type='text/css'>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be //fonts.googleapis.com/css?family=Lato:100 with out protocol :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joecohens Changed just now.. :) 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I commented and 1 second later you second commit was pushed lol.

@RomainLanz
Copy link

👍

@DavidLemayian DavidLemayian changed the title Use https to fetch Lato font Use no protocol to fetch Lato font Jan 28, 2015
@GrahamCampbell
Copy link
Member

Should be squashed to one commit. :)

@DavidLemayian
Copy link
Contributor Author

@GrahamCampbell Lol.. Sorry about that. Moments of epiphany got me doing two commits. :)

@joecohens
Copy link
Contributor

Lol

When using https://example.com, the welcome page design looks off due to fetching the Lato font on http://.

Ref: laravel/framework#7159

Better yet, instead of https:// or http://, //
@DavidLemayian
Copy link
Contributor Author

@joecohens This is all your fault. :-P :)

@GrahamCampbell Done. Does that work?

@yasinkocak
Copy link

Does this work on local machine with localhost?

@GrahamCampbell
Copy link
Member

Does this work on local machine with localhost?

I don't see why it wouldn't?

@dwightwatson
Copy link
Contributor

Relative links will work as long as the page is served (unlike say, opening a HTML file from your local disk in your browser).

taylorotwell added a commit that referenced this pull request Feb 4, 2015
Use no protocol to fetch Lato font
@taylorotwell taylorotwell merged commit 4552d93 into laravel:develop Feb 4, 2015
@DavidLemayian
Copy link
Contributor Author

Awesome! Thank you @taylorotwell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants