Have logical default for Queue Driver when testing #3265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume this wasn't done because the default is already sync? |
|
Mmmm...maybe - but if people change the default (because they want Redis on all environments for example) - then they need to add this line. Just a tweak either way - no biggie... |
|
People should set their queue driver in the env file though? |
|
Not necessarily. I only use |
|
👍 |
taylorotwell
added a commit
that referenced
this pull request
Feb 23, 2015
Have logical default for Queue Driver when testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should set the queue driver to be
syncwhen testing by default. Makes sense along side the other testing defaults like cache and session etc