Skip to content

Glyphicons are absent from Bootstrap #3273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2015
Merged

Glyphicons are absent from Bootstrap #3273

merged 1 commit into from
Feb 23, 2015

Conversation

theravel
Copy link

Laravel uses Bootstrap styles, which use font-family "Glyphicons Halflings".
This font is supposed to be loaded from "../fonts" (relatively to css), see links here. Actually the whole fonts directory is absent, that's why I cannot do fresh Laravel installation and use Glyphicons.

Are Glyphicons allowed to be included to Laravel by license?

@rossedman
Copy link

I may be wrong and @GrahamCampbell may correct me, but I believe they were trying to keep the styles included as minimal as possible, this would include extra bloat like fonts. You can always setup a quick bower install and pull down the full Bootstrap and begin compiling.

To me it is easier if you want to Bootstrap to pull the whole thing down rather than have thousands of people who don't want it having to delete it everytime they do an install.

@theravel
Copy link
Author

@rossedman maybe you are right, but currently CSS file contains broken links. Is this good?

@juukie
Copy link
Contributor

juukie commented Feb 20, 2015

Sorry but I really don't like the font files to be added. Imo, it has enough boilerplate files already.

@cleanunicorn
Copy link

It shouldn't be broken. Either provide the font files or remove the CSS. Modifying the CSS is a hackish solution, I prefer adding the font files to complete the application.

taylorotwell added a commit that referenced this pull request Feb 23, 2015
Glyphicons are absent from Bootstrap
@taylorotwell taylorotwell merged commit 7a5a5c7 into laravel:master Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants