Skip to content

ignore maintenance mode down file #3348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2015
Merged

ignore maintenance mode down file #3348

merged 1 commit into from
Apr 23, 2015

Conversation

browner12
Copy link
Contributor

No description provided.

@GrahamCampbell
Copy link
Member

Rejected in #3239.

@franzliedke
Copy link
Contributor

Please reconsider. Laravel should take care (as in gitignoring them) of files that it generates.

@GrahamCampbell
Copy link
Member

It's not up to me to reconsider. Taylor has closed at least one of these before, however, I can leave this open for him again if you want. :)

@franzliedke
Copy link
Contributor

👍

@browner12
Copy link
Contributor Author

sorry about that. i should have looked to see if this was already an open issue.

i'm curious, what is the thought behind NOT wanting to add it to .gitignore? while it is obviously a very obscure issue, it did happen to me once when i was testing my down template. as such I added it to my personal .gitignore file, because i wouldn't want pushing that file to version control to affect my production environment.

@paulrose
Copy link

Things like maintenance mode shouldn't be dictated by the framework. It's a user choice. The way some people deploy is automated and they wouldn't necessarily login to a server and to a site down command.

This shouldn't be part of the gitignore on a project level, it's a per user choice.

@GrahamCampbell
Copy link
Member

Things like maintenance mode shouldn't be dictated by the framework.

It still is the user's choice. This pull request is asking us to change the default for a new laravel project, that's all.

taylorotwell added a commit that referenced this pull request Apr 23, 2015
ignore maintenance mode `down` file
@taylorotwell taylorotwell merged commit 50cf908 into laravel:master Apr 23, 2015
@taylorotwell
Copy link
Member

I'll just merge for the sake of not bikeshedding forever.

@browner12 browner12 deleted the patch-1 branch April 23, 2015 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants