Change package.json so changed to elixir will be non-breaking changes #3358
Conversation
… in versions only.
|
+1 |
| @@ -2,6 +2,6 @@ | |||
| "private": true, | |||
| "devDependencies": { | |||
| "gulp": "^3.8.8", | |||
| "laravel-elixir": "*" | |||
| "laravel-elixir": "~1.0.0" | |||
There was a problem hiding this comment.
Per http://browsenpm.org/package.json
^1.0.0 would >= 1.0.0 and < 2.0.0 (could include breaking changes)
whereas
~1.0.0 would be >= 1.0.0 and < 1.1 (should only be patches, not breaking changes)
"The hope here, is that the package author has followed best-practices and patch versions of the package will NOT be breaking." - taken from the above referenced guide.
There was a problem hiding this comment.
"Best practices" would mean minor versions arn't breaking either...
There was a problem hiding this comment.
This is true. Are you recommending I modify my pull request, then?
There was a problem hiding this comment.
Not sure. Ping @taylorotwell and @JeffreyWay regarding how elixer will be versioned.
There was a problem hiding this comment.
^1.0.0.
Thanks for the PR.
There was a problem hiding this comment.
Changed. Ready for merge.
|
+1 |
1 similar comment
|
👍 |
Change package.json so changed to elixir will be non-breaking changes
Previous default version was "*"