[5.1] Move copying .env.example to post-root-package-install #3398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
post-create-project-cmd is executed only after post-install-cmd and this could cause issue on the first installation (via composer create-project) where environment is not prepared hence `php artisan optimize` would generate `compiled.php`. Signed-off-by: crynobone <crynobone@gmail.com>
749dcef to
2ac993f
Compare
|
Rebased. |
taylorotwell
added a commit
that referenced
this pull request
Jun 2, 2015
[5.1] Move copying .env.example to post-root-package-install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
post-create-project-cmd is executed only after post-install-cmd and this
could cause issue on the first installation (via composer
create-project) where environment is not prepared hence
php artisan optimizewould generatecompiled.php.Current Behaviour
post-install-cmdexecutephp artisan optimizewhile.envdoesn't exist (env=production & debug=false).post-create-project-cmdexecute copying.env.exampleand generate key.Expected Behaviour
post-root-package-cmdcopy.env.exampleto.envso we can have (env=local & debug=true).post-install-cmdexecutephp artisan optimizewith correct.env.post-create-project-cmdgenerate key.Refer to https://getcomposer.org/doc/articles/scripts.md#command-events
Signed-off-by: crynobone crynobone@gmail.com