Use the ::class notation #3410
Merged
Use the ::class notation #3410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... Looks nice: I have seen this notation in PHPStorm, but couldn't find anything about its function in official documents or web. |
|
Yea, I realized after seeing #3402 and PRs derived from there on. |
|
👍 |
|
👎 from me |
|
@GrahamCampbell IMO the reference of User's model at ModelFactory.php needs to be changed. |
|
@GrahamCampbell : what is different here from #3402 and its derivatives? |
|
@taylorotwell : Quick question - having non-FQNS here, won't break the code, will it? I mean, leading-back-slashes are missing. :) |
|
None of these files are namespaced so it will be fine. |
This was referenced Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.