Skip to content

Set minimum stability to stable #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2015
Merged

Conversation

barryvdh
Copy link
Contributor

Prevent people from using unstable package by default. Also affects what composer chooses.

Example: composer require symfony/dom-crawler will get:

Using version ^3.0@dev for symfony/dom-crawler

With stable, they get the correct version (^2.7)

As far as I know, previous versions of Laravel always shipped with stable as default, don't know why that has changed?

Fixes #3419 and #3414

@GrahamCampbell
Copy link
Member

The prefer-stable thing ensures that that doesn't happen.

@GrahamCampbell
Copy link
Member

It's a bug in composer if it gives you 3.0 when you run that command. Report it to them please. :)

@taylorotwell taylorotwell reopened this Jun 14, 2015
taylorotwell added a commit that referenced this pull request Jun 14, 2015
Set minimum stability to stable
@taylorotwell taylorotwell merged commit 5033b85 into laravel:master Jun 14, 2015
@brunogaspar
Copy link
Contributor

👍

@GrahamCampbell
Copy link
Member

This was modified after merge btw.

@barryvdh
Copy link
Contributor Author

No problem, just glad it's fixed. Thanks

@barryvdh barryvdh deleted the patch-1 branch June 15, 2015 11:00
@proshanto
Copy link

👍

@barryvdh
Copy link
Contributor Author

Guys this is merged already, no need to +1 anymore.

@KluVerKamp
Copy link

+1 for finally merge it! it makes more sens to have composer set like that

@laravel laravel locked and limited conversation to collaborators Jun 18, 2015
@GrahamCampbell
Copy link
Member

it makes more sens to have composer set like that

It makes no difference. It loads the identical dependencies before and after this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants