Skip to content

Remove unguard call #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2015
Merged

Remove unguard call #3511

merged 1 commit into from
Oct 4, 2015

Conversation

JosephSilber
Copy link
Contributor

It's now done in the seeder command: laravel/framework#10474

@crynobone
Copy link
Member

Remove unused import?

taylorotwell added a commit that referenced this pull request Oct 4, 2015
@taylorotwell
Merge pull request #3511 from JosephSilber/no-unguard
b1b33c8 
Remove unguard call
@taylorotwell taylorotwell merged commit b1b33c8 into laravel:develop Oct 4, 2015
@shehi
Copy link

shehi commented Oct 5, 2015

Why was this merged? Those lines actually were exactly what taught me how to use unguard and reguard features without even checking the docs. IMHO they should've just been commented out, instead of direct removal.

@veelasky
Copy link

veelasky commented Oct 5, 2015

+1 with shehi.

@dryhurst
Copy link

dryhurst commented Oct 5, 2015

+2

On Mon, Oct 5, 2015 at 12:47 AM, Rifki Alhuraibi notifications@github.com
wrote:

+1 with shehi.

—
Reply to this email directly or view it on GitHub
#3511 (comment).

Jonathan P Dryhurst Roberts
jonathan.dryhurst@gmail.com
US: 562-230-5691
UK: 07402 852 007

@benjamincrozat
Copy link

Same here: why mass assignment restrictions should be enabled when seeding the database?

@arrilot
Copy link

arrilot commented Oct 9, 2015

They are not enabled now. Please read the Joseph's comment

@benjamincrozat
Copy link

Yes sorry. It's much better like that.

@shehi
Copy link

shehi commented Oct 9, 2015

@arrilot : Oops, sorry, missed that as well. -1 [retracting my question] :)

@JosephSilber JosephSilber deleted the no-unguard branch November 17, 2015 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JosephSilber @crynobone @shehi @veelasky @dryhurst @benjamincrozat @arrilot @taylorotwell