Skip to content

Conversation

Jheysoon
Copy link

No description provided.

@bkintanar
Copy link

ignoring IDE files are best left to the developer since I don't think laravel will be ignoring all of the IDE files that exists.

@jahvi
Copy link

jahvi commented Oct 14, 2015

OS and IDE-specific files should be ignored in a global .gitignore file

@mvdstam
Copy link

mvdstam commented Oct 14, 2015

Seriously don't get these kind of PR's, which keep coming back for some reason. Here's why it's a bad idea:

  • Appending rules for IDE's to the .gitignore file is a slippery slope. There are a lot of IDE's out there; are we going to add them all?
  • The .gitignore file should only contain project specific rules. IDE-specific files (and OS files, such as the .DS_Store files) should be ignored in a global .gitignore file, as @jahvi states
  • Boilerplate configuration files that come with Laravel, including the .gitignore file should be as clean and simple as possible. Adding stuff because "it's handy" to files that everyone will check out in their projects can have unforeseen consequences.

@kamui545 kamui545 mentioned this pull request Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants