Why was this merge closed? I thought it was a fair change that made sense and consistent with the rest of the framework.

The command suffix is redundant since we're in the commands namespace.

On Wed, Nov 25, 2015 at 9:22 PM, Yahya Uddin notifications@github.com
wrote:

Why was this merge closed? I thought it was a fair change that made sense and consistent with the rest of the framework.

Reply to this email directly or view it on GitHub:
#3574 (comment)

Although I agree with you, it should be noted this is inconsistent with the rest of the framework.

For example consider the controllers: "AuthController" and "PasswordController" which sits in the "Controller" directory.

Or consider the "AppServiceProvider", "AuthServiceProvider", "EventServiceProvider", "RouteServiceProvider" in the "Providers" directory.

Not to mention the files in https://github.com/laravel/framework/tree/5.1/src/Illuminate/Foundation/Console

Therefore I think consistency is more important.

However, with that said I think you have a point and I would suggest removing the words "Provider" and "Controller" from these classes.

But consistency beats shorthand

No. I am not obligated to name it consistently with the framework core commands, whose class names aren't even exposed to the user, if I no longer feel like that is the best way to name commands.

On Thu, Nov 26, 2015 at 5:17 AM, Yahya Uddin notifications@github.com
wrote:

But consistency beats shorthand

Reply to this email directly or view it on GitHub:
#3574 (comment)

fair enough