Allow passing multiple gaurds to the auth middleware #3685
Conversation
|
I think the check might should be changed to |
|
Thoughts? |
aaf5766 to
703197e
Compare
|
@taylorotwell updated. |
| return response('Unauthorized.', 401); | ||
| } else { | ||
| return redirect()->guest('login'); | ||
| if ($this->check($guards)) { |
There was a problem hiding this comment.
Looks weird to put success condition before failed condition, in Middleware.
There was a problem hiding this comment.
It's not weird at all. You just maybe haven't seen it be done that way.
I actually like it quite a bit. It decreases the level of indentation, which is always a good thing.
|
Would anyone ever want this to be an "and" check instead of an "or" check? |
|
For an "and" check, you can just run the middleware twice: ->middleware('auth|auth:api'); |
|
Make it OR please. Not every JSON request is an AJAX request. |
|
And why "allow" has become synonymous with "make it mandatory"?! Why |
Allow passing multiple gaurds to the auth middleware
|
|
Using this, you'd be able to allow access to a single route for multiple guards: