Skip to content

Fixed up the phpunit config #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2016
Merged

Fixed up the phpunit config #3725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,15 @@
stopOnFailure="false">
<testsuites>
<testsuite name="Application Test Suite">
<directory>./tests/</directory>
<directory suffix="Test.php">./tests</directory>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to have this changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one is not necessary, but is more useful.

</testsuite>
</testsuites>
<filter>
<whitelist>
<directory suffix=".php">app/</directory>
<whitelist processUncoveredFilesFromWhitelist="true">
<directory suffix=".php">./app</directory>
<exclude>
<file>./app/Http/routes.php</file>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the really important change - it is NOT cosmetic - it stops phpunit requiring this file when searching for uncovered files

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I retract my statement of it being cosmetic :D LOL, thanks for awesome solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we just exclude ./app/Http/routes.php file without introducing other changes (we could make that the new default on 5.3)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have Laravel-5.2 based code (AudithSoftworks/Basis) and I always have
it up-to-date with the latest Laravel. I update it to the letter, as far
as I can, unless those updates are not necessary due to my own
modifications.

On 01-04-2016 08:03, Joseph Silber wrote:

In phpunit.xml
#3725 (comment):

     </testsuite>
 </testsuites>
 <filter>

  •    <whitelist>

  •        <directory suffix=".php">app/</directory>

  •    <whitelist processUncoveredFilesFromWhitelist="true">

  •        <directory suffix=".php">./app</directory>

  •        <exclude>

  •            <file>./app/Http/routes.php</file>
    Why are we so concerned about breaking BC in the app skeleton? Do
    people actually update their existing apps? How?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/laravel/laravel/pull/3725/files/28ea52d10b69b5cdf6fe72fe2acb5594022e1a8e#r58162725

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend adding some kind of XML comment into that file, notifying
users. We have comments everywhere, why not in this file as well?

On 01-04-2016 07:02, Mior Muhammad Zaki wrote:

In phpunit.xml
#3725 (comment):

     </testsuite>
 </testsuites>
 <filter>

  •    <whitelist>

  •        <directory suffix=".php">app/</directory>

  •    <whitelist processUncoveredFilesFromWhitelist="true">

  •        <directory suffix=".php">./app</directory>

  •        <exclude>

  •            <file>./app/Http/routes.php</file>

Shouldn't we just exclude |./app/Http/routes.php| file without
introducing other changes (we could make that the new default on 5.3)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/laravel/laravel/pull/3725/files/28ea52d10b69b5cdf6fe72fe2acb5594022e1a8e#r58160091

</exclude>
</whitelist>
</filter>
<php>
Expand Down