Call shouldUse on Auth when using the Authorize middleware
#3750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I imagine most people would expect to just be able to use `Auth::user()` or inject Guard and be able to just do `->user()` in their app if the user has been piped through this middleware as something other than the default guard. But they won't be able to without this as they won't be authed on that specific guard so they will instead receive `null` when expecting a user instance (considering they've been 'authenticated') right?. This is an issue that annoys me when developing a simple front-end and api in the same app. Is there any particular reason this isn't already the case? I completely expect this behaviour... I'm 96% sure it's not just me.
|
We already made this change for 5.3. |
|
For reference: #3718 |
|
Ooh, sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I imagine most people would expect to just be able to use
Auth::user()or inject Guard and be able to just do->user()in their app if the user has been piped through this middleware as something other than the default guard. But they won't be able to without this as they won't be authed on that specific guard so they will instead receivenullwhen expecting a user instance (considering they've been 'authenticated') right?.This is an issue that annoys me when developing a simple front-end and api in the same app. Is there any particular reason this isn't already the case? I completely expect this behaviour... I'm 96% sure it's not just me.