Skip to content

[5.3] Add config for new Memcached features #3768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2016
Merged

[5.3] Add config for new Memcached features #3768

merged 1 commit into from
May 1, 2016

Conversation

tomcastleman
Copy link
Contributor

Adds config for persistent connections, SASL authentication, and custom options

@tomcastleman
Add config for new Memcached features
9dc2d60 
Adds config for persistent connections, SASL authentication, and custom options
@tomcastleman tomcastleman changed the title Add config for new Memcached features [5.3] Add config for new Memcached features Apr 30, 2016
@taylorotwell
Copy link
Member

In this case the credentials count would always be 2 and it would always try to add credentials even though the env function will return null if the variables doesn't exist. I think the SASL section should be commented out.

@tomcastleman
Copy link
Contributor Author

tomcastleman commented May 1, 2016 •
edited
Loading

That was my reasoning for using array_filter in CacheManager which would mean credentials count would be < 2 unless both env variables were set.

@taylorotwell taylorotwell merged commit 3173f1c into laravel:develop May 1, 2016
@taylorotwell
Copy link
Member

Ah OK.

@scoutman57 scoutman57 mentioned this pull request Sep 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomcastleman @taylorotwell