[5.3] Enabled MySQL "strict" mode by default #3777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
YES!!! |
|
I hope ORM isn't depending on something non-strict. |
|
I feel like this could create potential issues. Strict mode also (at least, off the top of my head):
I feel like it should just be up to the developer to validate their data ;) but I guess it's an easy enough config change to reverse if preferences necessitate it. |
|
I think this makes sense and we'll document it. Timestamps in Laravel have defaulted to nullable for a while now to avoid errors with strict mode. |
|
And as @chelseau notes, easy to reverse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "strict" mode is set to false it allows the database to ignore significant errors rather than abort and return the error to PHP. An example would be trying to save a string in an INT field...instead of throwing an error, the save completes successfully and simply inserts a 0 in the field.
This means that the default setting allows for data loss with no notification, which seems like a really bad thing. The default should be to the safest setting, which could then be reconfigured by the developer if necessary.