[5.3] Make the Authenticate middleware throw an AuthenticationException #3783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dca5a70 to
b069ff0
Compare
|
This can't be merged without solution for redirect URI. |
|
@taylor currently, we ship the full response logic in laravel/laravel, and allow people to tweak it there. Can't we do the same here? Ship the whole |
|
Sure, change the PR to do that |
|
@taylorotwell should we make the base exception handler an abstract class, and create an abstract |
|
I don't see any need for that really. |
|
Just do what we said a few comments ago. |
|
@taylorotwell done. |
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of this change, so that we can unify unauthenticated responses.