Skip to content

Add missing Mandrill secret keys in config.services #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2016

Conversation

luqmanrom
Copy link
Contributor

@luqmanrom luqmanrom commented May 29, 2016

Add the Mandrill array in config.services to access the secret key from the .env.

@luqmanrom
Copy link
Contributor Author

In Transport manager, it is using this value in config to send email. It will be better if the secret key is stored in .env so that it will not be shared with others

protected function createMandrillDriver()
    {
        $config = $this->app['config']->get('services.mandrill', []);

        return new MandrillTransport(
            new HttpClient(Arr::get($config, 'guzzle', [])), $config['secret']
        );
    }

@GrahamCampbell
Copy link
Member

I think they were intentionally removed since mandrill is not used as much as it was before due to it no longer being free.

@luqmanrom
Copy link
Contributor Author

Ahh. I see. @taylorotwell actually clarified in here. Since Laravel is supporting it and most tutorials out there assumes the config.services is still accessing the secret key from the .env that only requires user to add secret key in .env , don't you think it is better to keep it for now to avoid error/confusions? Or maybe from the TransportManager#createMandrillDriver, get the secret key value directly from .env

@taylorotwell taylorotwell merged commit b402405 into laravel:master May 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants