Create an app ThrottleRequests middleware #3796
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it's necessary to include this in the default app. |
|
I didn't feel too that it was necessary before, but it turns out that this is the only middleware that I have to override on each projects |
|
I think this is very much needed to be in default app. |
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to allow a quicker extension of
\Illuminate\Routing\Middleware\ThrottleRequestsThe original middleware is good for most standard cases but does not bring some useful features.
Use cases can be so numerous that it would not make sense to put all of them in the original middleware.
Instead this PR allows the user to quickly override
\Illuminate\Routing\Middleware\ThrottleRequestsIt tends to mimic what has been done for
\App\Exceptions\Handler::report