Compliance with commonly used phpmd rules #3854
Conversation
|
You should really instruct phpmd to allow use $e instead of this pr. 👍 for the else statement tho :) |
|
This is the only file in the app folder that uses a short variable name. Personally, I feel like $exception is better as it's more descriptive, but I guess thats a decision for the approver. I'm happy to pull those out and just leave the else fix. |
|
I believe @taylorotwell wanted to leave that if/else in place as he preferred the indentation, showing a clearer path through that method. It was quashed in a previous PR, IIRC. |
|
It's generally accepted and preferred to use |
|
Have to modify that file every time :P |
|
phpmd needs fixing then |
|
Thanks for the merge. Be good for some option to ignore $e when used for exceptions within phpmd, didn't see one myself. There's one for ignoring e on short variables but could be in the code anywhere as that. |
Compliance with commonly used phpmd rules laravel/laravel#3854
This is a totally extraneous PR that just fixes a few things that we commonly see with our usage of Laravel and phpmd.
Php Mess Detector (phpmd) takes a given PHP source code base and looks for several potential problems within that source. Including possible bugs, suboptimal code, overcomplicated expressions, unused parameters, methods, properties, etc.
This PR fixes a few minor things that phpmd complains about with every new project we make. Specifically this replaces variable names that are too short ($e) and removes an extraneous
elsestatement.