give newbees a package service providers section, preventing adding after application #3855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter application
when i started, i ended up putting all package specific service providers just at the bottom of the application service providers. But when making a route group like domain.com/{keyword}, the packages that are registering its own url's, not work anymore (like now when i installed the translations manager from barryvdh). When putting them above the app specific, everything works. So just give it to the user as a default place?
|
why is this check failed? :S i didn't change any code, only comments... |
|
There's still cs rules there. Don't worry about it though. StyleCI will auto-fix after merge. |
|
Ah, thanks @GrahamCampbell :) will you be merging my suggestion? ;) |
|
Up to Taylor to decide. :) |
|
I always add this myself, though, I typically call it "Third Party Service Providers", nonetheless, it would be nice to see this merged. |
|
yeah, thats good for me too @brayniverse |
|
On a side note, the first thing I do is delete these comments. |
|
hahaha |
|
that's your choice ;) |
|
I do this also, and I leave the comments ;) But yeah 👍 for this, especially prevents problems with a catch-all route in your own Provider. |
|
@GrahamCampbell haha, well I guess it's down to personal taste. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when i started, i ended up putting all package specific service providers just at the bottom of the application service providers. But when making a route group like domain.com/{keyword}, the packages that are registering its own url's, not work anymore (like now when i installed the translations manager from barryvdh). When putting them above the app specific, everything works. So just give it to the user as a default place?