Skip to content

Fix missing word in docblock #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2016
Merged

Fix missing word in docblock #3865

merged 2 commits into from
Aug 7, 2016

Conversation

svenluijten
Copy link
Contributor

the word "framework" was missing in the docblock above Vue in resources/js/bootstrap.js.

I managed to make the docblock fit Laravel's style by changing around some of the wording while keeping the general message the same.

the word "framework" was missing. I also managed to make the docblock
fit Laravel's style by changing around some of the wording while keeping
the general message the same.
@brunocascio
Copy link

brunocascio commented Aug 7, 2016

Vuejs is a library rather than framework :)

Simple yet powerful library for building modern web interfaces. http://vuejs.org

Docs: https://github.com/vuejs/vue

@svenluijten
Copy link
Contributor Author

Damnit you're right. Let me fix that and change the wording around some
more.

On Aug 7, 2016 04:13, "Bruno" notifications@github.com wrote:

Vuejs is not a framework. Is a library. :)

Simple yet powerful library for building modern web interfaces.
http://vuejs.org

Docs: https://github.com/vuejs/vue


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3865 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AKv2A3mDsDrOI-JxyJYiCyE3DuUp3L8Gks5qdT80gaJpZM4JeXLZ
.

@svenluijten
Copy link
Contributor Author

What do you think about it now, @brunocascio? 😄

@brunocascio
Copy link

Great @svenluijten 💃

* simple, leaving you to focus only on building your next great idea.
* Vue is a modern JavaScript library for building interactive web interfaces
* using reactive data binding and reusable components. Vue's API is clean
* and simple, leaving you to focus on building your next great project.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we dropped the comma on this line, we'd have perfect alignment. 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would decrease readability though, @GrahamCampbell 😄

@taylorotwell taylorotwell merged commit 1b126d0 into laravel:develop Aug 7, 2016
@svenluijten svenluijten deleted the javascript-docblock-missing-word branch August 7, 2016 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants