Environment configuration for HTTPS only cookie #3922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -161,7 +161,7 @@ | |||
| | | |||
| */ | |||
|
|
|||
| 'secure' => false, | |||
| 'secure' => env('SESSION_SECURE_COOKIE', false), | |||
There was a problem hiding this comment.
I think SESSION_COOKIE_SECURE is a better name
There was a problem hiding this comment.
Was trying to match the other names with the SESSION_ prefix. If you're open to breaking trend, I like SECURE_SESSION_COOKIES best.
There was a problem hiding this comment.
I think SESSION_SECURE is the right choice, because we already have SESSION_DOMAIN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this likely changes between environments, figured it should be part of the environment configuration. Not entirely happy with the name though. While descriptive,
SESSION_HTTPS_ONLY_COOKIESseemed long.