[5.3] Map API routes before Web routes #3929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe a comment about this should be added in the code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing SPAs, it makes sense to have a 'catchall' route and then handle the routing with javascript (like with
vue-router). It would also make sense to have some API endpoints for the SPA to talk to.However, if you were to add a catchall to the
web.phproutes and then some API endpoints to theapi.phproutes, theapi.phproutes would be ignored as the catchall takes precedence, sinceweb.phproutes are mapped first.This PR proposes that we map API routes first, so that those routes take priority before a catchall / similar route is set by
web.php.Here is the proposal in
internals: laravel/ideas#187