-
Notifications
You must be signed in to change notification settings - Fork 24.5k
Removing .idea from .gitignore #3930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
is this ever going to end? is this really important? is this worth your time? the clock is ticking, go outside. life is beautiful. |
@jonagoldman Having this file in the .gitignore will just increase the number of PR's, as it will encourage the creation of them. IK that it was merged because people were tired of it but it will only make things worse. |
This is why I suggested PR templates!!!! On Mon, Sep 5, 2016 at 8:41 AM, Fernando Henrique Bandeira <
|
sigh |
This literally doesn't even matter. :/ |
Well i'm closing this, honestly for me it doesn't matter if this file has every single IDE and OS files being ignored or not i just think that ignoring .idea and not .DS_STORE or any other common file is nonsense since there is no standard and it will encourage other people to create PR's adding the "missing" files. |
I think it's a good idea to have it |
it does't matter. there will always be a PR to either add it or remove it. its kind of a quantum thing. |
You know what? Maybe it would help to replace
That way, chances are, that people visit the .gitignore file in order to add IDE specific ignores, but follow the better practice after they have read your comment. This might even reduce the amount of PRs on that. |
@tpraxl That sounds good, i'm not creating the PR though. |
IDE's and OS specific files shouldn't be in the project .gitignore, they should be added manually.
The reason i'm removing this even thought it was recently merged is because having this here will open the doors for many other PR's for specific IDE's and OS files, as you can check here: #3926
Also at least when i start a new project PHPStorm asks to include .idea in the .gitignore automatically so theres no benefit on having this as default.
Note
At this point probably people are pretty tired of .gitignore PR's so maybe we should just add a template for PR's and give a warning there to at least decrease the number of PR's including IDE's and OS files.