Skip to content

Conversation

fernandobandeira
Copy link
Contributor

@fernandobandeira fernandobandeira commented Sep 5, 2016

IDE's and OS specific files shouldn't be in the project .gitignore, they should be added manually.

The reason i'm removing this even thought it was recently merged is because having this here will open the doors for many other PR's for specific IDE's and OS files, as you can check here: #3926

Also at least when i start a new project PHPStorm asks to include .idea in the .gitignore automatically so theres no benefit on having this as default.

Note
At this point probably people are pretty tired of .gitignore PR's so maybe we should just add a template for PR's and give a warning there to at least decrease the number of PR's including IDE's and OS files.

@jonagoldman
Copy link

jonagoldman commented Sep 5, 2016

is this ever going to end? is this really important? is this worth your time? the clock is ticking, go outside. life is beautiful.

@fernandobandeira
Copy link
Contributor Author

@jonagoldman Having this file in the .gitignore will just increase the number of PR's, as it will encourage the creation of them. IK that it was merged because people were tired of it but it will only make things worse.

@scoutman57
Copy link

This is why I suggested PR templates!!!!

On Mon, Sep 5, 2016 at 8:41 AM, Fernando Henrique Bandeira <
notifications@github.com> wrote:

@jonagoldman https://github.com/jonagoldman Having this file in the
.gitignore will just increase the number of PR's, as it will encourage the
creation of them. IK that it was merged because people were tired of it but
it will only make things worse.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#3930 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA2C1Uqs0LXR4Rmmn-KhI5I_lP7q9ucdks5qnBv1gaJpZM4J1D6n
.

@GrahamCampbell
Copy link
Member

sigh

@GrahamCampbell
Copy link
Member

This literally doesn't even matter. :/

@fernandobandeira
Copy link
Contributor Author

Well i'm closing this, honestly for me it doesn't matter if this file has every single IDE and OS files being ignored or not i just think that ignoring .idea and not .DS_STORE or any other common file is nonsense since there is no standard and it will encourage other people to create PR's adding the "missing" files.

@fernandobandeira fernandobandeira deleted the patch-1 branch September 5, 2016 14:08
@FWSimon
Copy link

FWSimon commented Sep 5, 2016

I think it's a good idea to have it

@jonagoldman
Copy link

it does't matter. there will always be a PR to either add it or remove it. its kind of a quantum thing.

@tpraxl
Copy link

tpraxl commented Sep 5, 2016

You know what? Maybe it would help to replace /.idea in .gitignore with

# Do not put IDE or OS specific ignores in your local .gitignore file 
# Instead ignore it globally. See this link: https://help.github.com/articles/ignoring-files/
# /.idea

That way, chances are, that people visit the .gitignore file in order to add IDE specific ignores, but follow the better practice after they have read your comment. This might even reduce the amount of PRs on that.

@fernandobandeira
Copy link
Contributor Author

@tpraxl That sounds good, i'm not creating the PR though.

@laravel laravel locked and limited conversation to collaborators Sep 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants