Support predis v1.1.1 #4051
Merged
Support predis v1.1.1 #4051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: `AUTH failed: ERR Client sent AUTH, but no password is set [tcp://127.0.0.1:6379]` According to predix release log: https://github.com/nrk/predis/releases/tag/v1.1.1
|
Does this break support for other versions? |
|
@GrahamCampbell The old versions of predis require a |
|
Weird, this version was released month's ago we should've known about this earlier IMHO. Also is there a relation with laravel/framework#15914 ? He's using predis 1.1.1 and he stated that
Perhaps it's related... |
|
Meh, this PR is totally broken according to my testing on a fresh Forge server with Predis 1.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:
AUTH failed: ERR Client sent AUTH, but no password is set [tcp://127.0.0.1:6379]According to predix release log: https://github.com/nrk/predis/releases/tag/v1.1.1