Fixed .gitignore #4094
Fixed .gitignore #4094
Conversation
Added : - composer.lock : is build metadata which is not part of the project, the state of dependencies should be controlled through how you're versioning them and not arbitrarily by the last developer to update them and commit the lock file. -composer.phar : ZIP-like. Removed : .idea is a JetBrains file, it has to be included in the global .gitignore, not in the local one (cf : http://www.craftitonline.com/2013/10/ignore-symfony2-phpstorm-files-like-a-pro-with-global-ignoring)
|
I agree with the However, i disagree with the The same for |
|
I understand your point of view thanks for sharing it with me. btw : composer.lock is there https://github.com/laravel/framework/blob/5.3/.gitignore , https://github.com/laravel/passport/blob/1.0/.gitignore ,... I should ask Taylor |
|
We're not changing this file anymore. |
|
I'm still curious why the |
|
@kevinvdburgt check this : #3877 Maybe Taylor is tired of the pr about |
|
Ah, I see, if that is the case I can understand that Taylor is tired about those PR's. And it is just a single line I can remove from my project if I don't want it :) |
Yes, but now we get other PR to remove it. 💀 |
|
@kevinvdburgt I also think it's a personal thing about @RomainLanz Saaad.... |
Because we get spammed with PRs to add it.
No IDE should have it's config put in our gitignore, since they belong in global ignore files, so it's nothing personal in that way. |
Removed :
.ideais a JetBrains file, it has to be included in the global .gitignore, not in the local one(cf : http://www.craftitonline.com/2013/10/ignore-symfony2-phpstorm-files-like-a-pro-with-global-ignoring)