Change hard-coded '/login' param to named route #4143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taylorotwell @kneipp - there is one small problem with this PR: on a brand new 5.4 install, you cause a "InvalidArgumentException - Route [login] not defined" if you try and hit the default route In saying that - the old behavior before this PR looks like it was a "404 NotFoundHttpException" (since there is no Not sure which is the lesser of two evils? Maybe the default should be to Leave it with you... |
bkrukowski
pushed a commit
to bkrukowski/laravel
that referenced
this pull request
Mar 10, 2017
Change hard-coded '/login' param to named route
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change hard-coded '/login' param to named route 'login'.
Adding a bit of flexibility to work with translations w/o need change Handler class:
Route::get('entrar', 'CustomController@showLoginForm')->name('login');