Added --watch-poll #4147
Closed
Added --watch-poll #4147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is problem with `npm run watch` (webpack doesn't detects a changes) without `--watch-poll`. I use Homestead.
|
@JeffreyWay thoughts? |
|
File watching is always a little strange with VMs. Some people have no issues, others need to opt for polling. Polling, as I understand it, puts a bit more strain on things, so it probably shouldn't be the default. Maybe we can make it more clear in the docs that |
|
Could you not add another script called watch-poll which would leave it built in but as an addition rather than have people have to customize |
|
That might be a better option. |
JeffreyWay
added a commit
that referenced
this pull request
Feb 21, 2017
Per #4147, this adds a new `npm run watch-poll` command, and dries up some of those long repetitive commands.
Merged
bkrukowski
pushed a commit
to bkrukowski/laravel
that referenced
this pull request
Mar 10, 2017
Per laravel#4147, this adds a new `npm run watch-poll` command, and dries up some of those long repetitive commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is problem with
npm run watch(webpack doesn't detects a changes) without--watch-poll. I use Homestead.