-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Added changelog #4186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added changelog #4186
Conversation
CHANGELOG.md
Outdated
|
||
### Changed | ||
- Use `smtp.mailtrap.io` as default `MAIL_HOST` ([#4182](https://github.com/laravel/laravel/pull/4182)) | ||
- Upgrade Laravel Mix to `0.8.3` ([#4174](https://github.com/laravel/laravel/pull/4174)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎 That PR didn't do anything anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, thanks. I'll omit thing that don't do anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D
I'm not sure it makes sense to have a change log in what is actually, a default application, since this doesn't represent the change log for somebodies app. |
One thing I could do is remove this from applications created via |
@taylorotwell: I just added |
On Stackoverflow I found [this question](https://stackoverflow.com/questions/71900068/how-to-find-out-the-laravel-app-laravel-laravel-version-and-where-is-it-defi ): > What I am interested in, is how to figure out which version (GitHub's tag) was used when the Laravel "app" was created? So not the [laravel/framework](https://github.com/laravel/framework) version, as this was already explained in the other answer, but the Laravel "starter app" [laravel/laravel](https://github.com/laravel/laravel) version? > (I am interested in this so I could compare the differences on GitHub, but I don't know which tag/branch was used when the original app was created over a year ago.) I found myself in a similar situation while ago. AFAIK there is no way to find out the version of the skeleton (not `laravel/framework`) which an app was bootstrapped from. As I can see in laravel#4186 it was an active decision in 2017 to leave CHANGELOG.md out of the releases. But I would argue that it would be helpful to be able to include the CHANGELOG.md as the README.md is included. Perhaps the decision of that time can be reconsidered? By including CHANGELOG.md developers will be able to compare their skeleton version with the current version, and easily find the relevant changes since the app got created. Developers who don't want to keep the file can delete it as they can delete the readme.
Make it easier to keep track of changes in the
laravel/laravel
repository.