Skip to content

Revert Queue Prefix #4247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2017
Merged

Revert Queue Prefix #4247

merged 1 commit into from
Apr 28, 2017

Conversation

laurencei
Copy link
Contributor

@laurencei laurencei commented Apr 28, 2017 •
edited
Loading

Although it wont affect anything - it might lead to confusion if people think it is still an option.

It can be added back if the feature is re-added at a later stage.

@GrahamCampbell
Copy link
Member

👍

@GrahamCampbell
Copy link
Member

I don't like the idea of a queue prefix anyway. 👎 on having that feature, even if the implementation did work.

@mateusjatenee
Copy link

I'm a little out of the loop — why was the feature removed on laravel/framework?

@GrahamCampbell
Copy link
Member

laravel/framework#18860 (comment)

@taylorotwell taylorotwell merged commit 2c6d764 into laravel:master Apr 28, 2017
@taylorotwell
Copy link
Member

@mateusjatenee because it didn't work.

@laurencei laurencei deleted the patch-1 branch April 28, 2017 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurencei @GrahamCampbell @mateusjatenee @taylorotwell