Skip to content

don't need it #4349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2017
Merged

don't need it #4349

merged 1 commit into from
Jul 25, 2017

Conversation

pierreneter
Copy link
Contributor

No description provided.

@taylorotwell taylorotwell merged commit 166d25b into laravel:master Jul 25, 2017
@joshmanders
Copy link
Contributor

Can we get some context here? I am not up-to-speed on my npm cli knowledge, but last I knew you had to pass -- to denote that the flags after should be passed along. Has this changed?

@hrodrigues1984
Copy link

The -- is related to #4196

@pierreneter
Copy link
Contributor Author

Oops. Sorry, my bad. @joshmanders right. https://docs.npmjs.com/cli/run-script

@robclancy
Copy link

Should default to yarn anyway.

@hultberg
Copy link

Just a question after watching some MRs in this repo, and I notice a lot of them are missing some kind of justification or explanation of their changes, and still gets merged. Is there some internal chat of some sort where this is done, shouldn't there be more explanation here why the lines changed by this MR was "not needed"?

@pierreneter
Copy link
Contributor Author

Please ignore this, it is my fault, I will be more careful in the next PR opening. And I will write descriptions, not just short ones. My bad.
:(

@joshmanders
Copy link
Contributor

IMHO any PR regardless if it's the next greatest thing to come to the framework should be closed without a proper title and description.

@marky291
Copy link

It is quite easy to see what code is and does with the changes tab, the creator of laravel also uses this simplistic titles as this does if you look through the history of commits.

@hultberg
Copy link

@pierreneter No worries, mistakes happen to the all of us. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants