Skip to content

Update Echo options for pusher in bootstrap.js #4525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 24, 2017
Merged

Update Echo options for pusher in bootstrap.js #4525

merged 2 commits into from
Dec 24, 2017

Conversation

pdziewa
Copy link
Contributor

@pdziewa pdziewa commented Dec 23, 2017

@antonkomarev
Copy link
Contributor

antonkomarev commented Dec 24, 2017 •
edited
Loading

While we are changing this code, maybe it will be better to have trailing comma?

// window.Echo = new Echo({
//     broadcaster: 'pusher',
//     key: 'your-pusher-key',
//     cluster: 'eu',
//     encrypted: true,
// });

This helps git to have cleaner diffs and webpack working well with it.

@taylorotwell taylorotwell merged commit b347461 into laravel:master Dec 24, 2017
@pdziewa pdziewa deleted the bootstrap-pusher-fix branch December 24, 2017 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdziewa @antonkomarev @taylorotwell