Skip to content

Conversation

guumo
Copy link

@guumo guumo commented Apr 17, 2018

Add new Environment variables for timezone, language, and fallback_locale.

 Add new Environment variables for timezone, language, and fallback_locale.
@overtrue
Copy link
Contributor

👎

@cyrildewit
Copy link

cyrildewit commented Apr 17, 2018

This was rejected already for a number of times: #4531, #4520, #4325, #4134, #4034, #4018, #3882, #3792, #3764, #3713, #3508 and #4637.

Quoting some answers:

You own the app, you can change these if needed.

Feel free to add this to your own app.

You can add this to your own project.

And so on...

No offense 😄 !

@guumo
Copy link
Author

guumo commented Apr 17, 2018

Hi! Thanks for reply! :)

I don't understand the reasons for reject the proposal.

You own the app, you can change these if needed.
Feel free to add this to your own app.
You can add this to your own project.

In the config/app, multiple variables using the environment variables to get value.
What is the difference between the "app name" and "app timezone"?

According to that criterion, I also own the application to change the name of the application

Thanks!

@guumo guumo closed this Apr 17, 2018
@guumo
Copy link
Author

guumo commented Apr 17, 2018

I understand the comment, but I do not understand what is the criterion to decide without a variable will be inside or outside the environment file, since the language, the time zone are just as important as the name of the application, I would even say that it is more likely that the language or the time zone depends on the environment that the name of the app.

@danny-den
Copy link

A recent pull request #4629 was merged and i think it makes sense because in config/services all other keys were already looking in .env. But if that's the criterion i don't get it, if i make a pull request for every key in config it gets bloated as @nicknick-io said and if i add only one will be rejected.

@guumo guumo reopened this Apr 18, 2018
@guumo
Copy link
Author

guumo commented Apr 18, 2018

I re-open pull request to discuss about the criterion of #4629, Thanks @DanielGuerrero94

@GuidoHendriks
Copy link

You probably have spent more time in this PR than you’d ever spend on adding it to all your future projects projects manually. 💁🏻‍♂️

@guumo
Copy link
Author

guumo commented Apr 18, 2018

It is probable. It is also likely that with this way of thinking, laravel would never have existed, since my PR is not for my projects, it is a criterion for the benefit of laravel.

@GuidoHendriks
Copy link

Spending time on changes like this that don’t solve any problems isn’t very productive. If this would be merged, we could as well add all of the config variables to .env. That doesn’t benefit Laravel at all.

@GrahamCampbell
Copy link
Member

Thanks, but this really was intentionally not provided out of the box.

@guumo
Copy link
Author

guumo commented Apr 18, 2018

Cambiar a español
As you can see, I'm not the only one who made this suggestion. this change would unify the criteria to establish environmental variables, I do not understand why it is so closed. Applying the change does not make Laravel worse, so it surely makes it better. To be really fair, we should know the number of people who personalize each environment variable from .env file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants