-
Notifications
You must be signed in to change notification settings - Fork 24.5k
Add new Environment variables #4640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add new Environment variables for timezone, language, and fallback_locale.
👎 |
This was rejected already for a number of times: #4531, #4520, #4325, #4134, #4034, #4018, #3882, #3792, #3764, #3713, #3508 and #4637. Quoting some answers:
And so on... No offense 😄 ! |
Hi! Thanks for reply! :) I don't understand the reasons for reject the proposal.
In the config/app, multiple variables using the environment variables to get value. According to that criterion, I also own the application to change the name of the application Thanks! |
I understand the comment, but I do not understand what is the criterion to decide without a variable will be inside or outside the environment file, since the language, the time zone are just as important as the name of the application, I would even say that it is more likely that the language or the time zone depends on the environment that the name of the app. |
A recent pull request #4629 was merged and i think it makes sense because in config/services all other keys were already looking in .env. But if that's the criterion i don't get it, if i make a pull request for every key in config it gets bloated as @nicknick-io said and if i add only one will be rejected. |
I re-open pull request to discuss about the criterion of #4629, Thanks @DanielGuerrero94 |
You probably have spent more time in this PR than you’d ever spend on adding it to all your future projects projects manually. 💁🏻♂️ |
It is probable. It is also likely that with this way of thinking, laravel would never have existed, since my PR is not for my projects, it is a criterion for the benefit of laravel. |
Spending time on changes like this that don’t solve any problems isn’t very productive. If this would be merged, we could as well add all of the config variables to |
Thanks, but this really was intentionally not provided out of the box. |
Cambiar a español |
Add new Environment variables for timezone, language, and fallback_locale.