Skip to content

[5.7] Fix running mix tasks error #4832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2018
Merged

[5.7] Fix running mix tasks error #4832

merged 1 commit into from
Oct 24, 2018

Conversation

daniel-banciulea
Copy link
Contributor

@daniel-banciulea daniel-banciulea commented Oct 23, 2018 •
edited
Loading

Before this PR, running php artisan preset none and then running all Mix tasks npm run production would output an error:

ERROR in ./resources/js/bootstrap.js
Module not found: Error: Can't resolve 'popper.js'

This PR turns it into a warning keeping the same behaviour as when bootstrap and jquery modules are missing:

WARNING in ./resources/js/bootstrap.js
Module not found: Error: Can't resolve 'popper.js'

@GrahamCampbell GrahamCampbell changed the title fix running mix tasks error [5.7] Fix running mix tasks error Oct 23, 2018
@taylorotwell taylorotwell merged commit f9cf7ff into laravel:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-banciulea @taylorotwell