[5.7] Sort phpunit environment variables alphabetically #4833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What the benefit of doing that?
…On Saturday, October 27, 2018, Roberto Aguilar ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#4833
Commit Summary
- Sort phpunit environment variables alphabetically
File Changes
- *M* phpunit.xml
<https://github.com/laravel/laravel/pull/4833/files#diff-0> (4)
Patch Links:
- https://github.com/laravel/laravel/pull/4833.patch
- https://github.com/laravel/laravel/pull/4833.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4833>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAucFybKMK9SzgMq4iqEc9n1-xOfsqsYks5upA-qgaJpZM4X9TOA>
.
--
Sent from mobile,
Please execuse my typos
|
|
Several parts of the framework are sorted alphabetically, for example, take a look at the It feels better to search for things when you know that they have a certain order and more importantly, when they are consistent. I was doing a framework upgrade and wanted to make sure that i wasn't missing a new environment variable, if this has the right order, you can paste the new file in your application and see the right git diff (like in this time where the |
|
@DojoGeekRA Well, I am not fully convinced as changing the order for the sake of easing the upgrade process. Lets wait what others have to say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.