Skip to content

[5.9] Minor grammar fix in readme.md #5010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Conversation

faliure
Copy link
Contributor

@faliure faliure commented Apr 25, 2019

Boost you and your team's skills

should be

Boost your and your team's skills

@marky291
Copy link

Boost “your” and “your” team skills?

Isn’t this implying the same thing. -_-

@faliure
Copy link
Contributor Author

faliure commented Apr 26, 2019

Boost “your” and “your” team skills?

Isn’t this implying the same thing. -_-

No, this is equivalent to "Boost your skills and your team's skills". Neither "boost you" nor "boost you skills" makes sense. Whose skills can you boost? Yours and your team's. There are certainly better phrasings, but the current one is simply wrong.

@driesvints driesvints changed the title Minor grammar fix in readme.md [5.9] Minor grammar fix in readme.md Apr 26, 2019
@taylorotwell taylorotwell merged commit 3995828 into laravel:master Apr 26, 2019
@faliure faliure deleted the patch-1 branch April 26, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants