Exclude StyleCI config from exported files #5012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that this file was being included when i ran the `laravel new` command and even though some developers will run StyleCI, the purpose of this file seems more like it ensures the repository quality rather than providing an starting point for this service.
driesvints
added a commit
that referenced
this pull request
Apr 30, 2019
This reverts commit a6bf241.
|
FYI: I've reverted this. This caused the entry to be added to the .gitattributes file in every Laravel install. Instead we'll strip out the file in the cabinet installs soon. |
|
Understood, thanks @driesvints! Reference: laravel/installer@67ba1ab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this file was being included when i ran the
laravel newcommand and even though some developers will run StyleCI, the purpose of this file seems more like it ensures the repository quality rather than providing an starting point for this service.On the other hand, this are really good defaults so i'm open minded about this, just wanted to make sure this wasn't an oversight 😃