[5.8] Update deprecated pusher option #5058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realodix
added a commit
to realodix/urlhub
that referenced
this pull request
Jul 11, 2019
This was referenced Sep 9, 2019
browner12
added a commit
to browner12/docs.beyondco.de
that referenced
this pull request
May 5, 2020
both 'encrypted' and 'useTls' are supported, but 'encrypted' is deprecated. laravel/laravel#5058
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at source code pusher php library:
https://github.com/pusher/pusher-http-php/blob/60148190da064d662caeceee9a920592b5aae78e/src/Pusher.php#L107-L113
Seems both options are supported, but they are saying
encryptedis deprecated.Also, Laravel documentation is showing the
useTLSinstead ofencrypted:https://laravel.com/docs/5.8/broadcasting