Skip to content

[6.x] Specifying the minimum version of nodejs to require cross-env #5217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

andrey-helldar
Copy link

@andrey-helldar andrey-helldar commented Jan 30, 2020

cross-env version update merged: #5216
This PR contains an indication of the minimum version of nodejs required for cross-env to work (also see #5212 (comment)).

@andrey-helldar andrey-helldar changed the title Specifying the minimum version of nodejs to install [6.x] Specifying the minimum version of nodejs to require cross-env Jan 30, 2020
@taylorotwell
Copy link
Member

I'm not sure I want to have more version constraints in here to maintain.

@andrey-helldar
Copy link
Author

@taylorotwell, well, then, it seems to me, you need to roll back the changes from #5216 because:

cross-env 5.2 require node >= 4.0
cross-env 6.0 require node >= 8.0
cross-env 7.0 require node >= 10.14

In #5216, changes were adopted from version 6 to version 7. Should I create a PR return to version 6?

@driesvints
Copy link
Member

@andrey-helldar but npm will warn anyone who attempts to install v7 with a lower NPM version than 10.14? Why should we keep these constraints ourselves?

@andrey-helldar
Copy link
Author

@driesvints, I think I did not immediately understand what Taylor wrote. This is a language barrier problem.

I agree, an additional check does not need to be introduced, but I saw Graham’s #5212 (comment) and decided to create this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants