Skip to content

[6.x] Bump fzaninotto/faker version to support PHP 7.4 #5218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2020
Merged

[6.x] Bump fzaninotto/faker version to support PHP 7.4 #5218

merged 1 commit into from
Jan 31, 2020

Conversation

arcanedev-maroc
Copy link
Contributor

Bumping fzaninotto/faker version to support PHP 7.4, especially when running composer with --prefer-lowest flag.

PRs related to version ^1.9.1:

Bumping `fzaninotto/faker` version to support PHP 7.4, especially when running composer with `--prefer-lowest` flag.

PRs related to version `^1.9.1`: 

* fzaninotto/Faker#1748
* fzaninotto/Faker#1843
@driesvints driesvints changed the title Bump fzaninotto/faker version to support PHP 7.4 [6.x] Bump fzaninotto/faker version to support PHP 7.4 Jan 30, 2020
@GrahamCampbell
Copy link
Member

Apps never run with --prefer-lowest, though. You are meant to commit your composer.lock.

@GrahamCampbell
Copy link
Member

--prefer-lowest is only for libraries to use to verify they work against a greatest lower bound.

@arcanedev-maroc
Copy link
Contributor Author

@GrahamCampbell There is a case when i develop locally a mutli-modules (laravel packages for a custom CMS) by using laravel/laravel in combination with composer repositories

Otherwise (for a single laravel package), i use orchestral/testbench. See the change: orchestral/testbench-core@6c199f7

I know it's not a critical because i can change the dependencies when i start a new project, but it's good to avoid any potential bugs.

@crynobone
Copy link
Member

I ask to escalates to laravel side because the laravel/framework doesn't requires faker in composer.json, it depends on testbench-core requirements.

https://twitter.com/driesvints/status/1222481311081910273?s=19

@driesvints
Copy link
Member

Let's see what Taylor says.

@driesvints driesvints reopened this Jan 30, 2020
@taylorotwell taylorotwell merged commit c78a1d8 into laravel:master Jan 31, 2020
@arcanedev-maroc arcanedev-maroc deleted the patch-2 branch January 31, 2020 13:56
socheatsok78 pushed a commit to pp-spaces/laravel that referenced this pull request Feb 23, 2020
Bumping `fzaninotto/faker` version to support PHP 7.4, especially when running composer with `--prefer-lowest` flag.

PRs related to version `^1.9.1`: 

* fzaninotto/Faker#1748
* fzaninotto/Faker#1843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants