[6.x] Remove redundant default attributes from phpunit.xml #5233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kinda stupid IDEs would warn about this. We included these options so people don't have to head to Google to know what the options are called to change them. |
I've never had to change any of these values, I actually don't know what most of these are supposed to do. Removing them would clean up some unnecessary noise in this file. |
|
Maybe keep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5139 added the xml schema to
phpunit.xml. Because of this, IDEs like PhpStorm now show which attributes are redundant:All the gray attributes in the screenshot above are setting the same value as the default value. They can be removed.
The
suffix="Test.php"is also a redundant default, but I think this is useful in reminding people their test classes should end withTest.php