Fixing "Cannot remove ...: Permission denied" in File and bundle:: task #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le:: CLI task. Signed-off-by: Pavel <proger.xp@gmail.com>
|
Nice fix! Would you mind sending this pull request on the develop branch? |
|
Sure. |
zoe-edwards
pushed a commit
to zoe-edwards/laravel
that referenced
this pull request
Oct 14, 2013
flap152
pushed a commit
to flap152/laravel
that referenced
this pull request
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavel proger.xp@gmail.com
Previously described in #538:
Setup: Windows XP SP3, XAMPP with PHP 5.3.
Problem:
File::rmdir(),File::cleandir(),Laravel\CLI\Tasks\Bundle\Providers\Provider::zipball()fail to remove directories even though they have successfully emptied them (zipball()fails to remove the temporary zip file).Cause: FilesystemIterator (
File) and ZipArchive (Provider) are locking the directory/zipfile so that the following rmdir()/unlink() fails.I'm not sure thought that the GC will 100% reliably be triggered after the FilesystemIterator is unset so there might be a room for improvements (e.g. using scandir() instead).
Also, unlike other FIle functions cpdir() doesn't use @ silencer on its rmdir(). Is this intended?