[8.x] Uses LazilyRefreshDatabase by default
#5696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorotwell
added a commit
that referenced
this pull request
Oct 5, 2021
This reverts commit 4578193.
taylorotwell
added a commit
that referenced
this pull request
Oct 5, 2021
This reverts commit 4578193.
|
I reverted this because it doesn't have a good story for usage with Dusk and also doesn't work with the documented The Dusk case is particularly annoying since this trait is used on the base test class there is no way to opt-out of it for your Dusk tests which need to use DatabaseMigrations instead of RefreshDatabase behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes
LazilyRefreshDatabasea default trait on the base test class for every new Laravel project. This way people don't need to worry about which test cases use the database or not - things will just work.If this pull request gets merged, we may need to adapt the documentation before next week's release.