[8.x] Update lte and gte validation messages to have a grammatically parallel structure #5699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify the grammar for lte and gte validation to have a parallel structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grammar for gte.numeric/file/string and lte.numeric/file/string do not currently appear to follow the concept of parallel structure, so can sound a little strange to some people's ears. To be parallel, we need the preposition for "equal" (to match the adjective + pronoun used with "greater than"), which would be "to" in this case. Given that these are short messages that are potentially seen by many people, I think having the grammar corrected would be good for the professionalism of those using Laravel as a framework.
Thanks!