Skip to content

[8.x] PHPDoc types should be covariant with the parent type #5714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

[8.x] PHPDoc types should be covariant with the parent type #5714

merged 1 commit into from
Oct 25, 2021

Conversation

canvural
Copy link
Contributor

The parent exception handler class has the type string[] for both dontReport and dontFlash. But the child handler class had only array Both types should be covariant. This PR fixes that.

@taylorotwell taylorotwell merged commit 1542783 into laravel:8.x Oct 25, 2021
@canvural canvural deleted the patch-1 branch January 23, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canvural @taylorotwell