Skip to content

[8.x] Remove redundant tap() helper in index.php #5719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021
Merged

[8.x] Remove redundant tap() helper in index.php #5719

merged 1 commit into from
Nov 5, 2021

Conversation

ad-mos
Copy link
Contributor

@ad-mos ad-mos commented Nov 5, 2021

Kernel@handle contract returns \Symfony\Component\HttpFoundation\Response, which in turn has a method send() that returns itself (Response). So there is no need for wrapping Response in HigherOrderTapProxy each time.

@GrahamCampbell GrahamCampbell changed the title Remove redundant tap() helper in index.php [8.x] Remove redundant tap() helper in index.php Nov 5, 2021
@taylorotwell taylorotwell merged commit ca8e5d6 into laravel:8.x Nov 5, 2021
@ad-mos ad-mos deleted the patch-1 branch November 5, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants