Skip to content

[8.x] Add types to arrays in boilerplate #5738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2021
Merged

[8.x] Add types to arrays in boilerplate #5738

merged 3 commits into from
Dec 2, 2021

Conversation

bram-pkg
Copy link

@bram-pkg bram-pkg commented Dec 2, 2021

I hope I've assumed all the types correctly.

driesvints
driesvints reviewed Dec 2, 2021
View reviewed changes
bram-pkg
bram-pkg commented Dec 2, 2021
View reviewed changes
@bram-pkg
Copy link
Author

bram-pkg commented Dec 2, 2021

Reverted the string|void. @driesvints

@taylorotwell taylorotwell merged commit 7bf3228 into laravel:8.x Dec 2, 2021
@bram-pkg bram-pkg deleted the add-array-types branch December 2, 2021 20:41
@xharpenParksuhyeon xharpenParksuhyeon mentioned this pull request Feb 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bram-pkg @driesvints @taylorotwell